fix: This fixes the issue with recent 2023 update where FindObjectsOfType was renamed to FindObjectsByType#2320
Merged
NoelStephensUnity merged 21 commits intodevelopfrom Nov 23, 2022
Conversation
This reverts commit 420768a.
ashwinimurt
reviewed
Nov 22, 2022
ashwinimurt
reviewed
Nov 22, 2022
0xFA11
reviewed
Nov 22, 2022
Cleaning up the adjustments so that as little code and how it is formatted is impacted (as possible).
0xFA11
reviewed
Nov 22, 2022
0xFA11
reviewed
Nov 23, 2022
| } | ||
|
|
||
| #if UNITY_2023_1_OR_NEWER | ||
| var networkObjects = UnityEngine.Object.FindObjectsByType<NetworkObject>(FindObjectsSortMode.InstanceID); |
Contributor
There was a problem hiding this comment.
I like how there's sort by InstanceId on the API built-in.
0xFA11
approved these changes
Nov 23, 2022
NoelStephensUnity
added a commit
that referenced
this pull request
Nov 23, 2022
…Type was renamed to FindObjectsByType (#2320) * update Adding the 2023.1.a21 FindObjectsByType fix for NGO using the UNITY_2023_1_OR_NEWER define. Modified a few of the FindObjectsSortMode for areas that looked like they might require their results ordered by InstanceID.
JesseOlmer
pushed a commit
that referenced
this pull request
Dec 1, 2022
…ch (#2325) fix: This fixes the issue with recent 2023 update where FindObjectsOfType was renamed to FindObjectsByType (#2320) * update Adding the 2023.1.a21 FindObjectsByType fix for NGO using the UNITY_2023_1_OR_NEWER define. Modified a few of the FindObjectsSortMode for areas that looked like they might require their results ordered by InstanceID.
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…ch (Unity-Technologies#2325) fix: This fixes the issue with recent 2023 update where FindObjectsOfType was renamed to FindObjectsByType (Unity-Technologies#2320) * update Adding the 2023.1.a21 FindObjectsByType fix for NGO using the UNITY_2023_1_OR_NEWER define. Modified a few of the FindObjectsSortMode for areas that looked like they might require their results ordered by InstanceID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue with recent 2023 update where FindObjectsOfType was renamed to FindObjectsByType